Now it is properly fixed without messing up fractionals

trnnick · Jul 11, 2018 · 9063cbd · 9063cbd
1 parent bfe8dc2
commit 9063cbd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: nnfor
 Type: Package
 Title: Time Series Forecasting with Neural Networks
-Version: 0.9.3
+Version: 0.9.4
 Authors@R: person("Nikolaos", "Kourentzes", email = "nikolaos@kourentzes.com",
                   role = c("aut", "cre"))
 Description: Contains functions to facilitate automatic time series modelling with neural networks. 

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
+# CHANGES IN NNFOR VERSION 0.9.4 (11 JUL 2018)
+- Fix for msts time series and allow.det.season argument.
+
 # CHANGES IN NNFOR VERSION 0.9.3 (01 Apr 2018)
-- CHanges in how trigonometric seasonal dummies are handled.
+- Changes in how trigonometric seasonal dummies are handled.
 
 # CHANGES IN NNFOR VERSION 0.9.2 (11 Dec 2017)
 - Documentation fixes.

diff --git a/R/mlp.R b/R/mlp.R
@@ -578,7 +578,7 @@ ndiffs.net <- function(difforder,y,ff,st){
 seas.dum.net <- function(st,difforder,det.type,ff,ff.n,Y,y,allow.det.season){
 # Create seasonal dummies for networks
 
-  if (if(ff.n > 1){TRUE}else{!any(difforder == max(ff))}
+  if ((if(ff.n > 1){TRUE}else{!any(difforder == max(ff))})
       & frequency(y)>1 & st$season.exist==TRUE & allow.det.season==TRUE){
     sdummy <- TRUE
     # Set type of seasonal dummies

diff --git a/sync.ffs_db b/sync.ffs_db