Fix require("console") oven-sh#3820 (oven-sh#4073)

* Fix oven-sh#3820 * Add Module (oven-sh#4074)
trnxdev · Aug 9, 2023 · acfd36a · acfd36a
1 parent b902693
commit acfd36a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/bun.js/module_loader.zig b/src/bun.js/module_loader.zig
@@ -2396,6 +2396,7 @@ pub const HardcodedModule = enum {
             .{ "node:child_process", .{ .path = "node:child_process" } },
             .{ "node:constants", .{ .path = "node:constants" } },
             .{ "node:console", .{ .path = "node:console" } },
+            .{ "console", .{ .path = "node:console" } },
             .{ "node:querystring", .{ .path = "node:querystring" } },
             .{ "querystring", .{ .path = "node:querystring" } },
             .{ "node:domain", .{ .path = "node:domain" } },

diff --git a/src/bun.js/modules/NodeModuleModule.h b/src/bun.js/modules/NodeModuleModule.h
@@ -292,11 +292,13 @@ DEFINE_NATIVE_MODULE(NodeModule) {
     exportNames.append(name);
     exportValues.append(value);
   };
-  exportNames.reserveCapacity(14);
-  exportValues.ensureCapacity(14);
+  exportNames.reserveCapacity(15);
+  exportValues.ensureCapacity(15);
   exportNames.append(vm.propertyNames->defaultKeyword);
   exportValues.append(defaultObject);
 
+  put(Identifier::fromString(vm, "Module"_s), defaultObject);
+
   putNativeFn(Identifier::fromString(vm, "createRequire"_s),
               jsFunctionNodeModuleCreateRequire);
   putNativeFn(Identifier::fromString(vm, "paths"_s),

diff --git a/test/js/node/module/node-module-module.test.js b/test/js/node/module/node-module-module.test.js
@@ -26,6 +26,10 @@ test("Module exists", () => {
   expect(Module).toBeDefined();
 });
 
+test("module.Module exists", () => {
+  expect(Module.Module === Module).toBeTrue();
+});
+
 test("_nodeModulePaths() works", () => {
   expect(() => {
     _nodeModulePaths();