Skip to content

Commit

Permalink
Merge pull request #1472 from troessner/prepare-v5.4.0
Browse files Browse the repository at this point in the history
Prepare v5.4.0.
  • Loading branch information
troessner committed Apr 24, 2019
2 parents 4f0b629 + 88fcbe1 commit 803686e
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 13 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

## 5.4.0 (2019-04-24)

* (Philippe Bernery) Enable regex for directory directives.

## 5.3.2 (2019-03-22)

* (troessner) Use Parser26.
Expand Down
4 changes: 2 additions & 2 deletions features/command_line_interface/options.feature
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Feature: Reek can be controlled using command-line options
-c, --config FILE Read configuration options from FILE
--smell SMELL Only look for a specific smell.
Call it like this: reek --smell MissingSafeMethod source.rb
Check out https://github.com/troessner/reek/blob/v5.3.2/docs/Code-Smells.md for a list of smells
Check out https://github.com/troessner/reek/blob/v5.4.0/docs/Code-Smells.md for a list of smells
--stdin-filename FILE When passing code in via pipe, assume this filename when checking file or directory rules in the config.
Generate a todo list:
Expand Down Expand Up @@ -120,5 +120,5 @@ Feature: Reek can be controlled using command-line options
UnusedPrivateMethod
UtilityFunction
Check out https://github.com/troessner/reek/blob/v5.3.2/docs/Code-Smells.md for a details on each detector
Check out https://github.com/troessner/reek/blob/v5.4.0/docs/Code-Smells.md for a details on each detector
"""
6 changes: 3 additions & 3 deletions features/reports/json.feature
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: Report smells using simple JSON layout
"context": "Smelly#x",
"lines": [ 4 ],
"message": "has the name 'x'",
"documentation_link": "https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Method-Name.md",
"documentation_link": "https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md",
"name": "x"
},
{
Expand All @@ -33,7 +33,7 @@ Feature: Report smells using simple JSON layout
"context": "Smelly#x",
"lines": [ 5 ],
"message": "has the variable name 'y'",
"documentation_link": "https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Variable-Name.md",
"documentation_link": "https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md",
"name": "y"
}
]
Expand All @@ -53,7 +53,7 @@ Feature: Report smells using simple JSON layout
1
],
"message": "has no descriptive comment",
"documentation_link": "https://github.com/troessner/reek/blob/v5.3.2/docs/Irresponsible-Module.md"
"documentation_link": "https://github.com/troessner/reek/blob/v5.4.0/docs/Irresponsible-Module.md"
}
]
"""
8 changes: 4 additions & 4 deletions features/reports/reports.feature
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ Feature: Correctly formatted reports
And it reports:
"""
smelly.rb -- 2 warnings:
[4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Method-Name.md]
[5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Variable-Name.md]
[4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md]
[5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md]
"""

Examples:
Expand All @@ -209,8 +209,8 @@ Feature: Correctly formatted reports
And it reports:
"""
smelly.rb -- 2 warnings:
UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Method-Name.md]
UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Variable-Name.md]
UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md]
UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md]
"""

Examples:
Expand Down
6 changes: 3 additions & 3 deletions features/reports/yaml.feature
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ Feature: Report smells using simple YAML layout
smell_type: UncommunicativeMethodName
source: smelly.rb
name: x
documentation_link: https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Method-Name.md
documentation_link: https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Method-Name.md
- context: Smelly#x
lines:
- 5
message: has the variable name 'y'
smell_type: UncommunicativeVariableName
source: smelly.rb
name: y
documentation_link: https://github.com/troessner/reek/blob/v5.3.2/docs/Uncommunicative-Variable-Name.md
documentation_link: https://github.com/troessner/reek/blob/v5.4.0/docs/Uncommunicative-Variable-Name.md
"""

Scenario: Indicate smells and print them as yaml when using STDIN
Expand All @@ -48,5 +48,5 @@ Feature: Report smells using simple YAML layout
lines:
- 1
message: has no descriptive comment
documentation_link: https://github.com/troessner/reek/blob/v5.3.2/docs/Irresponsible-Module.md
documentation_link: https://github.com/troessner/reek/blob/v5.4.0/docs/Irresponsible-Module.md
"""
2 changes: 1 addition & 1 deletion lib/reek/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ module Reek
# @public
module Version
# @public
STRING = '5.3.2'
STRING = '5.4.0'
end
end

0 comments on commit 803686e

Please sign in to comment.