ExcessiveConstantUsage smell

[troessner]

I think such a smell would be really helpful.

E.g. code like this:

class Omg
  FOO = ....
  BAR = ....
  WALDFEE = ....
end

would reek of this smell. The category for this smell would be "SRP violation" in my mind.

What are your thoughts on this?

[mvz]

How would you resolve this smell if it occurs?

[troessner]

How would you resolve this smell if it occurs?

For me ExcessiveConstantUsage is similar to TooManyInstanceVariables

[chastell]

The devil, as usual, is in the detail. How many is too many? 😈

[troessner]

How about the same as for TooManyInstanceVariables, so 4?

[chastell]

I’m not sure how well it’s going to play with your campaign against literals in code. ;)

[troessner]

YMMD :)

[troessner]

Cleaning up our issues: Linked this issue in #556 - closing this one.

[mvz]

Reopening this since we now have a candidate implementation.

[troessner]

Closing this one with #956 merged.