Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not detect ModuleInitialize for nested dynamic classes #1287

Merged
merged 1 commit into from
Jan 6, 2018
Merged

Do not detect ModuleInitialize for nested dynamic classes #1287

merged 1 commit into from
Jan 6, 2018

Conversation

mvz
Copy link
Collaborator

@mvz mvz commented Jan 5, 2018

@chastell
Copy link
Collaborator

chastell commented Jan 6, 2018

LGTM, thanks! I reran the rogue Travis jobs and they’re all green now. 🙌

@chastell chastell merged commit 6f87bcc into master Jan 6, 2018
@chastell chastell deleted the issue-1137-fix-module-initialize-false-positive branch January 6, 2018 12:39
@chastell chastell mentioned this pull request Jan 6, 2018
Closed
@chastell
Copy link
Collaborator

chastell commented Jan 6, 2018

Gaah, there should probably be a matching CHANGELOG.md entry. @mvz can you add it? Sorry!

@mvz
Copy link
Collaborator Author

mvz commented Jan 6, 2018

Well, we do tend to only add those when we release, but I'll make a proposal.

@mvz mvz mentioned this pull request Jan 6, 2018
Merged
@jimeh jimeh mentioned this pull request Jan 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvz @chastell