Fix JRuby build #1401
Merged
Fix JRuby build #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still to do: SimpleCov. |
mvz
force-pushed
the
fix-jruby-build
branch
from
5d8c0fb
to
1b1f609
Compare
|
|
|
Actually, seems like we're using undefined behavior by calling it as What we're doing creates |
This clears up the spec by starting from an empty environment, so the expectation tests the requirement more directly.
JRuby does not perform automatic conversion from RuntimeError to String.
There are two reasons for this: - Coverage is not collected at all unless JRUBY_OPTS="--debug" is set, which slows down tests massively. - Coverage percentage differs from the result on CRuby, making this check unreliable.
Java and hence JRuby always emits a message about this environment variable, causing problems in output expectations.
The use of a first argument with a leading slash is undefined, breaks on JRuby, and wasn't doing anything useful on MRI either. We can just use the argument-less version.
troessner
approved these changes
Dec 3, 2018
|
Nice clean up. I'm happy to merge this as it is. Do you want to keep the current number of commits? |
Yes, they carry some nice comments on the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JRuby build and makes it required.