Fix Instance Variable Assumption false positive #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troessner
approved these changes
Oct 10, 2023
mvz
approved these changes
Oct 10, 2023
JuanVqz
force-pushed
the
fix-false-positive-of-instance-variable-assumption-with-struct-initialize
branch
from
e5a086f
to
033f00a
Compare
|
@troessner and @mvz thank you for having a look, I rebased it 👍 |
|
Thanks @JuanVqz! |
JuanVqz
deleted the
fix-false-positive-of-instance-variable-assumption-with-struct-initialize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can you please have a look?
I hope this fixes #1492
What this basically does is look up through all the initializers if it matches the
ivasgnto consider it instance variable assumption.