Fix Module with initialize method #1746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
commented
Oct 18, 2023
JuanVqz
force-pushed
the
fix_module_initialize
branch
2 times, most recently
from
476f9ec
to
47c9730
Compare
JuanVqz
changed the title
troessner
requested changes
Oct 19, 2023
|
1 small comment from my side, other than that, this looks great. Wdyt @mvz ? |
JuanVqz
force-pushed
the
fix_module_initialize
branch
from
47c9730
to
4f95a44
Compare
mvz
requested changes
Oct 21, 2023
| @@ -21,14 +21,16 @@ def self.contexts # :nodoc: | |||
| # @return [Array<SmellWarning>] | |||
| # | |||
| def sniff | |||
| context.defined_instance_methods.each do |node| | |||
There was a problem hiding this comment.
Apparently, the cause of #1505 is that ModuleContext#defined_instance_methods includes methods from dynamically defined nested classes. Instead of dropping down to bare sexp manipulation, I think this method should be adjusted instead.
There was a problem hiding this comment.
Do you have any clue where can I start?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505