New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ultra verbose warning formatter. #305
Conversation
18c9b66
to
1881373
Compare
@mvz ready for review. 2 remarks: 1.) We'd need to rename our wiki pages accordingly so that they match SmellWarning#subclass, but I don't see this as a problem. |
1.) Not really a problem I think. |
@@ -88,6 +88,9 @@ def set_options | |||
@parser.on('-V', '--no-quiet', '--verbose', 'Show headings for smell-free source files') do |_opt| | |||
@strategy = Report::Strategy::Verbose | |||
end | |||
@parser.on('-U', '--ultra-verbose', 'Try to be as explanatory as possible') do |_opt| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would drop the 'Try to' here.
I think this PR is a good start for ultra-verbose mode. I'd like to continue this by adding some explanatory text in the output itself. What do you think? |
1881373
to
a9cc0f3
Compare
@mvz I addressed all your comments, thanks for the feedback!
Yes, makes sense.
Please go ahead..:) |
…atter Add ultra verbose warning formatter.
Actually I forgot that github generates all those links out of the wiki pages title. instead of |
In regards to issue #302