Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to explain that Reek can't parse new Ruby 1.9 hashes #91

Merged
merged 1 commit into from Nov 6, 2011

Conversation

jcf
Copy link
Contributor

@jcf jcf commented Nov 3, 2011

What do you think to explaining Reek won't be able to analyse files containing new 1.9 hashes? Does this belong in the README or else where?

@arwagner
Copy link
Contributor

arwagner commented Nov 6, 2011

I appreciate you submitting this. Just curious, can you describe what problems you had with the syntax, though? ruby_parser doesn't blow up when it tries to parse it:

/Users/andrewwagner/ruby> echo '{a: 3}' > foo.rb
/Users/andrewwagner/ruby> cat foo.rb
{a: 3}
/Users/andrewwagner/ruby> reek foo.rb
foo.rb -- 0 warnings

On the other hand, it also doesn't successfully parse it:
ruby-1.9.2-p290 :001 > require 'ruby_parser'
=> true
ruby-1.9.2-p290 :002 > RubyParser.new.parse "{a: 3}"
=> nil

What behavior did you see? Thanks again!

arwagner added a commit that referenced this pull request Nov 6, 2011
Update README to explain that Reek can't parse new Ruby 1.9 hashes
@arwagner arwagner merged commit c0fa181 into troessner:master Nov 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants