Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: winging code to another Lingualeo API change #52

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

troggy
Copy link
Owner

@troggy troggy commented Oct 3, 2019

The problem is that Lingualeo API is broken itself — it doesn't even work on their own website to me.

I have 1400 words in "5 years ago" group, yet it shows me just 12 words on the website
image

@troggy troggy mentioned this pull request Oct 3, 2019
@troggy
Copy link
Owner Author

troggy commented Oct 3, 2019

I will try to use their older API, for some reason it still works and works differently

@troggy troggy merged commit c10d306 into master Oct 8, 2019
@troggy troggy deleted the fix/another-leo-change branch October 8, 2019 13:31
@dreambit
Copy link

@troggy Hi.

I suppose they have introduced lazy loading(infinite scroll) so in order to load entire list of words u have to scroll down.
Also calling GetWords without wordIds does not return context.

So the first obvious workaround is to call GetWords with filled wordIds.

I’ve solved this problem by calling first GetWords to get all my words and then call to GetWords for each word to get a context.

@troggy
Copy link
Owner Author

troggy commented Jul 20, 2020

I’ve solved this problem by calling first GetWords to get all my words and then call to GetWords for each word to get a context.

this is exactly what the code removed in this PR was doing.

However, I've just found it is not needed — you can add "context" to the attributes in the request and get the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants