Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show all scripts executed from rc.local or runparts #127

Closed
troglobit opened this issue May 8, 2020 · 2 comments · Fixed by #146
Closed

Always show all scripts executed from rc.local or runparts #127

troglobit opened this issue May 8, 2020 · 2 comments · Fixed by #146
Assignees
@jackuess
Milestone
v4.0

Comments

@troglobit
Copy link
Owner

... or at least make it configurable. Many embedded systems use this feature to extend,
or even live-patch systems between major upgrades of firmware. Security wise it is a
good thing to at least show on the console what scripts are executed outside the normal
bootstrap path.
@troglobit troglobit added this to the v4.0 milestone Feb 10, 2021
@jackuess
Copy link
Contributor

@troglobit For rc.local I don't think there's much more we can do since execution of the script is handed over to whatever is in the shebang in rc.local. All we can do is show on the console that rc.local is called, and that's already implemented.

For the runparts part, i guess some output like this would suffice:

[ STATUS ] Calling /rc.d/0001-foo
[ STATUS ] Calling /rc.d/0002-bar

@jackuess jackuess self-assigned this Feb 12, 2021
@troglobit
Copy link
Owner Author

Sounds more than reasonable. Ah, thanks had completely forgotten about that! Great, the runparts progress should be fairly straight forward 👍

jackuess added a commit that referenced this issue Feb 12, 2021
@jackuess
Fix #127: communicate run-parts progress/status
0557c83 
Printing the progress of run-parts script just like for `rc.local`
seems reasonable. Also log a warning if any script exits abnormally.

Signed-off-by: Jacques de Laval <jacques@de-laval.se>
@jackuess jackuess linked a pull request Feb 12, 2021 that will close this issue
Fix #127: communicate run-parts progress/status #146
Merged
troglobit added a commit that referenced this issue Feb 12, 2021
@troglobit
Merge pull request #146 from troglobit/show-runparts-progogress
fec8530 
Fix #127: communicate run-parts progress/status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackuess jackuess

Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Fix #127: communicate run-parts progress/status troglobit/finit
2 participants
@troglobit @jackuess