Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implicit "initctl reload" after runparts #52

Closed
troglobit opened this issue Nov 28, 2016 · 0 comments
Closed

Add implicit "initctl reload" after runparts #52

troglobit opened this issue Nov 28, 2016 · 0 comments

Comments

@troglobit
Copy link
Owner

A user of an embedded system may want to extend/modify services declared in /etc/finit.d/ at boot
via runparts /some/other/path.

When scripts in the run-parts(8) directory have run, Finit should check if any service/tasklet/runlet have
been made "dirty" and then reload them.

troglobit added a commit that referenced this issue Feb 26, 2018
Issue #52 suggested calling service_reload_dynamic() automatically after
run-parts and /etc/rc.local.  This may seem like a good idea, but not
only does it create extra overhead, it currently also freezes the boot
and fails to present a login prompt if a run-parts directory exists.
Yes, the directory can be empty, it just have to exist to trigger this
regression.

While trying to find the root cause I realized this was all just wrong.
If the user does something that requires reloading finit, they should
call `initctl reload` from the script instead.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant