Westermo fixes for UDP inetd services and more #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both the new initctl API and the new pidfile watcher plugin failed to set CLOEXEC on their sockets. This caused forked-off and exec()'d children to inherit all these descriptors. Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This patch fixes several issues related to the problem of launching UDP inetd services: - Make sure to disable O_NONBLOCK on the socket before passing it to the inetd service, that's what is expected. This goes for both UDP and TCP (accepted) connections -- there is no guarantee even for TCP sockets that they do *not* inherit the parent socket's flags. - Mark the UDP inetd parent's SVC as busy and stop its watcher before starting the child task to service the connection. The watcher must be stopped or multiple child tasks may be spawned! - Only copy the most relevant parts to the UDP task. In particular must *not* copy the libuEv watcher data to the task! - With the child task done and the parent inetd service unblocked we must restore O_NONBLOCK to the socket before restarting the watcher When a UDP inetd service connection is handled we create a child task to service the request, meanwhile we block the parent service. There was a problem with blocking the parent since we called inetd_stop(), which both did a shutdown() and close() of the socket ... this patch introduces separate handling of blocked (busy) inetd services in the inetd_stop() function and also make sure to handle restarting the parent watcher in inetd_start() when the child task is done. Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
When starting an inetd service in verbose mode we print a progress message to the console appended with "Connection". This patch simply changes that to append with "connection" in lower case. Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Both the original MIT Athena inetd and the GNU inetutils inetd only keep a backlog of 10 connections in listen() for TCP sockets. This patch adjusts the Finit hard coded default accordingly. Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joachim Nilsson joachim.nilsson@westermo.se