Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the 2 problems with the current namecheap support and also updates the
README.md
to reflect that.The first problem stems from the
good
andnochg
strings no longer getting sent back, makinginadyn
think the request failed (while it might not have).The example in the
README.md
on the other hand will always succeed, sincetrue
is always in the response, even if it failed. Refer to the examples below.I have decided to replace both with a check for
<ErrCount>0</ErrCount>
.faulty response
successful response
The second problem is
username
andhostname
being swapped inNAMECHEAP_UPDATE_IP_REQUEST
causing it to senddomain=%h
,host=%u
instead ofdomain=%u
,host=%h
. While we can work around this by swappingusername
andhostname
in the config, this means we cannot specify multiple hostnames.I have swapped the two fields and think it is worth this breaking change for ease of use, especially since the plugin is currently broken and people couldn't be relying on it anyways.
current option (custom provider)
current option (plugin)
new option