Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript ? #10

Closed
klevron opened this issue Mar 2, 2021 · 3 comments
Closed

Typescript ? #10

klevron opened this issue Mar 2, 2021 · 3 comments
Labels
enhancement New feature or request refactoring
Milestone
0.3

Comments

@klevron
Copy link
Member

klevron commented Mar 2, 2021

No description provided.

@klevron klevron added the enhancement New feature or request label Mar 20, 2021
klevron added a commit that referenced this issue Apr 3, 2021
@klevron
defineComponent for geometries (#10)
f6ecd08
klevron added a commit that referenced this issue Apr 3, 2021
@klevron
defineComponent for core components (#10)
885268f
klevron added a commit that referenced this issue Apr 3, 2021
@klevron
defineComponent for meshes and simplify (#10)
168289c
klevron added a commit that referenced this issue Apr 4, 2021
@klevron
defineComponent for lights (#10)
09290f9
klevron added a commit that referenced this issue Apr 4, 2021
@klevron
defineComponent for materials (#10)
a1d7862
klevron added a commit that referenced this issue Apr 4, 2021
@klevron
defineComponent for effects (#10)
98c74aa
klevron added a commit that referenced this issue Apr 4, 2021
@klevron
defineComponent for model loaders (#10)
2dae674
klevron added a commit that referenced this issue Apr 4, 2021
@klevron
defineComponent for components (#10)
db5aca7
@klevron
Copy link
Member Author

klevron commented Apr 15, 2021

WIP : https://github.com/troisjs/trois/tree/typescript

@klevron
Copy link
Member Author

klevron commented Apr 19, 2021 •
edited

Well, not easy, I have problems with option/composition api :

Option inject don't work properly (bug ? or maybe my typescript config ?) I have the following error :

Property '...' does not exist on type 'CreateComponentPublicInstance<Readonly<{...}>

It works when using inject() in setup()

Example here : https://github.com/troisjs/trois/blob/971f37e29b6d0a675f3debb8e9f48c8985f1aa3c/src/core/Camera.ts

@klevron
Copy link
Member Author

klevron commented Apr 19, 2021

Another problem is using a custom defineComponent function to define components (e.g. meshes)

@klevron klevron added this to the 0.3 milestone Apr 26, 2021
@klevron klevron closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactoring
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@klevron