Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useQuery returns cached data when there is an error #100

Merged
merged 1 commit into from
Mar 25, 2019
Merged

useQuery returns cached data when there is an error #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/useQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,17 @@ export function useQuery<
() => {
const result = observableQuery.currentResult();

// return the old result data when there is an error
let data = result.data as TData;
if (result.error || result.errors) {
data = {
...result.data,
...(observableQuery.getLastResult() || {}).data,
};
}

return {
data: result.data as TData,
data,
error:
result.errors && result.errors.length > 0
? new ApolloError({ graphQLErrors: result.errors })
Expand Down