Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive save may fail silently #5

Open
chestnutprog opened this issue Sep 10, 2021 · 0 comments
Open

Archive save may fail silently #5

chestnutprog opened this issue Sep 10, 2021 · 0 comments

Comments

@chestnutprog
Copy link

chestnutprog commented Sep 10, 2021 •
edited

When the archive file is locked by another program, the archive save will silently fail.
Should we consider checking the return value of file operations, or replacing them with std::filesystem?

https://github.com/troldal/Zippy/blob/a838de8522f9051df0d1b202473bb6befe648702/library/Zippy/ZipArchive.hpp#L491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chestnutprog