Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use devcontainer, redocly bundle, and stub Jekyll site #17

Merged
merged 14 commits into from
Jan 3, 2024

Conversation

caindy
Copy link
Contributor

@caindy caindy commented Jan 2, 2024

This addresses #12

@caindy caindy linked an issue Jan 2, 2024 that may be closed by this pull request
@caindy caindy marked this pull request as ready for review January 2, 2024 01:57
docs/index.md Show resolved Hide resolved
Copy link
Contributor

@getorymckeag getorymckeag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I appreciate all the screwing around with Jekyll. I really love how you were able to make this monster of a spec modular. There are a few things you left todo (like the email in one of the configs, links in the markdown). I'm OK with calling this good and cleaning that up in a separate PR later if you want. Or add to this one and I'll re-approve.

@catkins-miso catkins-miso self-requested a review January 3, 2024 20:28
@catkins-miso catkins-miso reopened this Jan 3, 2024
@catkins-miso catkins-miso merged commit 5ee73ab into 1.0.0-wip Jan 3, 2024
4 checks passed
@catkins-miso catkins-miso deleted the redocly branch January 4, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAPI spec and documentation transclusion
3 participants