Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add snapshot-header to snapshots, update examples #49

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

caindy
Copy link
Contributor

@caindy caindy commented Feb 12, 2024

No description provided.

@caindy caindy changed the title add snapshot-header to forecast limits detailed snapshot add snapshot-header to snapshots, update examples Feb 12, 2024
@caindy caindy marked this pull request as ready for review February 13, 2024 16:13
Copy link
Contributor

@getorymckeag getorymckeag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion when you add excalidraws- maybe export the .excalidraw file and find a home for it in the repo so that other contributors don't have to redraw the diagram to make edits over time if necessary. If you want to add that now, go ahead and I'll re-approve, or just add it later.

docs/concepts.md Show resolved Hide resolved
@caindy
Copy link
Contributor Author

caindy commented Feb 15, 2024

One suggestion when you add excalidraws- maybe export the .excalidraw file and find a home for it in the repo so that other contributors don't have to redraw the diagram to make edits over time if necessary. If you want to add that now, go ahead and I'll re-approve, or just add it later.

I use the *.excalidraw.png extension when creating the file. For example:
https://github.com/trolie/spec/blob/1.0.0-wip/docs/images/TROLIE%20Ratings%20Provider%20interactions.excalidraw.png

The VS Code plugin for excalidraw is the default editor for that extension, and it basically embeds the excalidraw source in the PNG format's comments. You can open these *.excalidraw.png files directly in standalone Excalidraw as well, happily.

@getorymckeag
Copy link
Contributor

One suggestion when you add excalidraws- maybe export the .excalidraw file and find a home for it in the repo so that other contributors don't have to redraw the diagram to make edits over time if necessary. If you want to add that now, go ahead and I'll re-approve, or just add it later.

I use the *.excalidraw.png extension when creating the file. For example: https://github.com/trolie/spec/blob/1.0.0-wip/docs/images/TROLIE%20Ratings%20Provider%20interactions.excalidraw.png

The VS Code plugin for excalidraw is the default editor for that extension, and it basically embeds the excalidraw source in the PNG format's comments. You can open these *.excalidraw.png files directly in standalone Excalidraw as well, happily.

Didn't know that, works for me.

@catkins-miso catkins-miso merged commit 152c661 into 1.0.0-wip Feb 15, 2024
3 checks passed
@caindy caindy deleted the update-snapshot branch February 23, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants