Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type for function definition that return enum #69

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

sydhds
Copy link

@sydhds sydhds commented Apr 22, 2020

From what I've seen, function that returns enum were returning boolean so fix that. I've included incomplete test for function but I could not find a way to add assert. Any hint is welcome :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 68.104% when pulling e587402 on sydhds:fix_func_return_enum into 2aeb194 on trolldbois:master.

@XVilka
Copy link

XVilka commented May 8, 2020

@trolldbois could you please take a look? PRs from @sydhds look good to be merged.

@trolldbois trolldbois merged commit fe597b5 into trolldbois:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants