small bug fixes

trolldbois · Jul 26, 2017 · 7eb3b77 · 7eb3b77
1 parent 1a03055
commit 7eb3b77
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/haystack/allocators/win32/winheapwalker.py b/haystack/allocators/win32/winheapwalker.py
@@ -25,7 +25,7 @@ class WinHeapWalker(heapwalker.HeapWalker):
     """
 
     def _init_heap(self):
-        log.debug('+ Heap @%0.8x size: %d # %s',self._heap_mapping.start, len(self._heap_mapping), self._heap_mapping)
+        log.debug('+ Heap @%0.8x size: %d # %s', self._heap_mapping.start, len(self._heap_mapping), self._heap_mapping)
         # real allocations from the process pov
         self._user_allocs = None
         self._user_free_chunks = None
@@ -57,6 +57,7 @@ def get_heap_validator(self):
 
     def __contains__(self, address):
         """ Does the heap walker or its relevant segments contains this address"""
+        # FIXME
         raise NotImplementedError('Please implement all methods')
 
     def get_backend_allocations(self):

diff --git a/haystack/mappings/file.py b/haystack/mappings/file.py
@@ -438,6 +438,7 @@ def __init__(self, memdump):
         self.size = memdump.tell()
         self.memdump_name = memdump.name
         memdump.seek(i)
+        # FIXME Why would you do that ?
         memdump.close()
 
     def __len__(self):

diff --git a/setup.py b/setup.py
@@ -78,7 +78,7 @@ def run(self):
             'console_scripts': [
                 'haystack-find-heap = haystack.cliwin:find_heap',
                 'haystack-search = haystack.cli:search',
-                'haystack-show = haystack.cli:main_show',
+                'haystack-show = haystack.cli:show',
                 'haystack-live-dump = haystack.memory_dumper:main',
                 'haystack-live-watch = haystack.cli:live_watch',
                 'haystack-rekall-dump = haystack.cli:rekall_dump',