fix(db): fix concurrent error #4665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halibobo1205
force-pushed
the
fix/db
branch
3 times, most recently
from
a657105
to
3fe8c8f
Compare
tomatoishealthy
approved these changes
Sep 22, 2022
|
15 |
halibobo1205
force-pushed
the
fix/db
branch
from
3fe8c8f
to
06cb141
Compare
1. add write lock for resetDb 2. add read lock for getStats 3. disable db metric for checkpointV2 db
halibobo1205
force-pushed
the
fix/db
branch
from
06cb141
to
8d27c0f
Compare
ulviyya889
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
resetDbandgetStatsis not locked properlytmpdatabase andcheckpointV2databases maybe close when involve getStats due to concurrent.This PR has been tested by:
Follow up
Extra details