Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): remove auto-repair for corrupted leveldb #5223

Conversation

halibobo1205
Copy link
Contributor

@halibobo1205 halibobo1205 commented May 18, 2023

What does this PR do?
Remove auto-repair for leveldb when db is corrupted.

Why are these changes required?
The repair function could not guarantee a full recovery of the data, this could lead to misjudging of the database integrity.

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

Codecov Report

Merging #5223 (8318708) into release_v4.7.2 (dcf8982) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                  @@
##             release_v4.7.2    #5223      +/-   ##
====================================================
+ Coverage             60.39%   60.48%   +0.09%     
- Complexity             9003     9014      +11     
====================================================
  Files                   836      836              
  Lines                 49681    49673       -8     
  Branches               5529     5528       -1     
====================================================
+ Hits                  30007    30047      +40     
+ Misses                17303    17253      -50     
- Partials               2371     2373       +2     
Impacted Files Coverage Δ
.../common/storage/leveldb/LevelDbDataSourceImpl.java 72.85% <100.00%> (+2.10%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@halibobo1205 halibobo1205 merged commit 0803151 into tronprotocol:release_v4.7.2 May 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants