Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitor): optimize http interface monitoring #5332

Merged

Conversation

xxo1shine
Copy link
Contributor

@xxo1shine xxo1shine commented Jul 3, 2023

What does this PR do?
Optimize http interface monitoring, for non-existent URL monitoring, only the total number of failures is monitored, and the details are not monitored.

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@xxo1shine xxo1shine changed the title feat(monitor): resolve http metrics problem feat(monitor): optimize http interface monitoring Jul 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5332 (e8a921f) into develop (dcd0ebd) will decrease coverage by 0.02%.
The diff coverage is 59.25%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff              @@
##             develop    #5332      +/-   ##
=============================================
- Coverage      60.79%   60.78%   -0.02%     
+ Complexity      9217     9214       -3     
=============================================
  Files            839      839              
  Lines          50031    50029       -2     
  Branches        5575     5574       -1     
=============================================
- Hits           30417    30409       -8     
- Misses         17238    17240       +2     
- Partials        2376     2380       +4     
Impacted Files Coverage Δ
...org/tron/core/services/filter/HttpInterceptor.java 63.15% <59.25%> (-4.35%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RZ7272 RZ7272 linked an issue Jul 4, 2023 that may be closed by this pull request
Closed
@xxo1shine xxo1shine merged commit 5007067 into tronprotocol:develop Jul 5, 2023
5 checks passed
@xxo1shine xxo1shine deleted the resolve_http_metrics_problem branch July 14, 2023 09:09
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 23, 2023
@halibobo1205 halibobo1205 removed a link to an issue Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants