Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sign): optimize the default value of validate sign thread number #5396

Conversation

lurais
Copy link
Contributor

@lurais lurais commented Aug 3, 2023

What does this PR do?
Use all available cpu cores to validate transaction signatures.
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-commenter
Copy link

Codecov Report

Merging #5396 (a1b41c2) into develop (9a65bb6) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff              @@
##             develop    #5396      +/-   ##
=============================================
- Coverage      60.92%   60.91%   -0.01%     
  Complexity      9231     9231              
=============================================
  Files            839      839              
  Lines          50029    50029              
  Branches        5574     5574              
=============================================
- Hits           30479    30476       -3     
- Misses         17165    17167       +2     
- Partials        2385     2386       +1     
Files Changed Coverage Δ
.../src/main/java/org/tron/core/config/args/Args.java 60.17% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomatoishealthy tomatoishealthy linked an issue Aug 3, 2023 that may be closed by this pull request
@tomatoishealthy
Copy link
Contributor

tomatoishealthy commented Aug 3, 2023

Better remember to link the issue with this PR.

Correct to the right link if I'm wrong

@tomatoishealthy tomatoishealthy changed the title feat(sign): optimize validate sign param feat(sign): optimize validate sign default param Aug 3, 2023
@tomatoishealthy tomatoishealthy changed the title feat(sign): optimize validate sign default param feat(sign): optimize the default value of validate sign thread number Aug 3, 2023
@lurais
Copy link
Contributor Author

lurais commented Aug 3, 2023

that's right. @guoquanwu

@halibobo1205 halibobo1205 merged commit 2bbc0fd into tronprotocol:develop Aug 9, 2023
7 checks passed
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.3 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the efficiency of signature verification
4 participants