feat(net): add column codeVersion to HelloMessage #5584
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
317787106
changed the title
lurais
reviewed
Nov 15, 2023
| builder.append("address:") | ||
| .append(StringUtil.encode58Check(address.toByteArray())).append("\n"); | ||
| } | ||
|
|
||
| ByteString signature = helloMessage.getSignature(); | ||
| if (signature != null && !signature.isEmpty()) { | ||
| if (!signature.isEmpty()) { |
There was a problem hiding this comment.
Is this field has some relationship with the codeVersion?
There was a problem hiding this comment.
Is this field has some relationship with the codeVersion?
No, only code optimization.
| builder.append("signature:") | ||
| .append(signature.toByteArray().length).append("\n"); | ||
| } | ||
|
|
||
| ByteString codeVersion = helloMessage.getCodeVersion(); |
There was a problem hiding this comment.
Will this codeVersion be null when received a HelloMessage from a node with previous version ?
There was a problem hiding this comment.
Every column in proto has default value. codeVersion has default value byte[0], not null.
lvs007
requested review from
tomatoishealthy,
xxo1shine,
jwrct and
halibobo1205
xxo1shine
approved these changes
Nov 21, 2023
jwrct
approved these changes
Nov 24, 2023
halibobo1205
approved these changes
Dec 27, 2023
Nouri11190
reviewed
Feb 25, 2024
Danyalkasiri
reviewed
Mar 2, 2024
| @@ -99,6 +100,9 @@ public void testOkHelloMessage() | |||
| Node node = new Node(NetUtil.getNodeId(), a1.getAddress().getHostAddress(), null, a1.getPort()); | |||
| HelloMessage helloMessage = new HelloMessage(node, System.currentTimeMillis(), | |||
| ChainBaseManager.getChainBaseManager()); | |||
|
|
|||
| Assert.assertEquals(Version.getVersion(), | |||
|
./ |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details