Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): delete config item node.discovery.bind.ip #5597

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

317787106
Copy link
Contributor

@317787106 317787106 commented Nov 23, 2023

What does this PR do?

  • delete config item node.discovery.bind.ip
  • update libp2p version, include snappy-java version

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@317787106 317787106 linked an issue Nov 23, 2023 that may be closed by this pull request
@317787106 317787106 changed the title feat(net): delete config item node.bind.ip feat(net): delete config item node.discovery.bind.ip Nov 23, 2023
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.7.4 milestone Nov 24, 2023
PARAMETER.nodeDiscoveryBindIp = s.getLocalAddress().getHostAddress();
} catch (IOException e) {
logger.warn("Can't get bind IP. Fall back to 127.0.0.1: " + e);
PARAMETER.nodeDiscoveryBindIp = "127.0.0.1";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this logic be retained?

Copy link
Contributor Author

@317787106 317787106 Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the external ip is not exist, use LAN IP.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcoded into www.baidu.com?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halibobo1205 It has been moved to libp2p module. This url is not necessary and we can use alternative way.

@317787106 317787106 merged commit a0f431c into tronprotocol:develop Dec 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete network config item - node.discovery.bind.ip
4 participants