feat(net): stop tx broadcasting if block cannot solidified #5643
Conversation
xxo1shine
changed the title
| if (tronNetDelegate.unsolidifiedBlockCheck()) { | ||
| logger.warn("Broadcast transaction {} has failed, block unsolidified.", txID); | ||
| return builder.setResult(false).setCode(response_code.BLOCK_UNSOLIDIFIED) | ||
| .setMessage(ByteString.copyFromUtf8("Bock unsolidified.")) |
There was a problem hiding this comment.
Please optimize the prompt message to make the user aware of the specific reason for the failure, such as too many blocks not being finalized.
There was a problem hiding this comment.
Bock unsolidified means this. It would be better to shorten this prompt message.
There was a problem hiding this comment.
Please check spelling, Block, not Bock.
|
|
||
| PARAMETER.maxUnsolidifiedBlocks = | ||
| config.hasPath(Constant.MAX_UNSOLIDIFIED_BLOCKS) ? config | ||
| .getInt(Constant.MAX_UNSOLIDIFIED_BLOCKS) : 1000; |
There was a problem hiding this comment.
The default value is determined how?
There was a problem hiding this comment.
Referring to the issue test data, I personally think 1000 is OK.
| if (tronNetDelegate.unsolidifiedBlockCheck()) { | ||
| logger.warn("Broadcast transaction {} has failed, block unsolidified.", txID); | ||
| return builder.setResult(false).setCode(response_code.BLOCK_UNSOLIDIFIED) | ||
| .setMessage(ByteString.copyFromUtf8("Bock unsolidified.")) |
There was a problem hiding this comment.
Please check spelling, Block, not Bock.
| long solidNum = chainBaseManager.getSolidBlockId().getNum(); | ||
| return headNum - solidNum >= maxUnsolidifiedBlocks; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please rename the method unsolidifiedBlockCheck. It should not be the same as varible, it is confusing.
xxo1shine
force-pushed
the
block_unsolid_solution
branch
from
1625f0b
to
bf8de17
Compare
| @@ -1051,6 +1051,8 @@ message Return { | |||
| SERVER_BUSY = 9; | |||
| NO_CONNECTION = 10; | |||
| NOT_ENOUGH_EFFECTIVE_CONNECTION = 11; | |||
| BLOCK_UNSOLIDIFIED = 12; | |||
There was a problem hiding this comment.
May be the reason TOO_MANY_BLOCK_UNSOLIDIFIED more clearful ? We generally believe that less than a certain number of unsodlified blocks is normal. It's tiny.
There was a problem hiding this comment.
Briefly describe what happened, too many doesn't make much sense.
What does this PR do?
Stop broadcasting transactions when the block cannot be solidified, refer to issue: #5562
Why are these changes required?
This PR has been tested by:
Follow up
Extra details