feat(net): verify columns' length of HelloMessage

[317787106]

What does this PR do?

• verify columns of hellomessage, including address, sig & codeVersio, length should not be over 200

Why are these changes required?

• avoid too long log for HelloMessage

This PR has been tested by:

• Unit Tests
• Manual Testing

Follow up

Extra details

[jwrct]

Is a maximum byte size of 200 too large? Can it be set smaller?

[317787106]

The target of method valid is to make sure that log's content is not too large, so the value of maxByteSize is not very important. The length of address may be 42 bytes or more (not certain), sig is 65, codeVersion may not stable(20 bytes?). Can you give a suggestion?

[jwrct]

Just take the maximum of the three values, for example 65.

[317787106]

In fact, I don't test the true length of address ang sig, because i have no fastforword node to use. Only give a theoretical value. Give an upper value can be ok, but give an exact value is not necessary, because method checkHelloMessage will verify the address and sig again. The main purpose is to not record too many message in log file.

[ss334452]

The length judgment of address and version can be more specific.
It is recommended to consider multi-signature within 3 keys, If there are 3 multi-signatures, will the length exceed 200?

[317787106]

this signature only come from SR's sig of timestamp in RelayService. it's 65 stablely, not related to multi-signature. You can read the code:

      String sig =
          TransactionCapsule.getBase64FromByteString(msg.getSignature());
      byte[] sigAddress = SignUtils.signatureToAddress(hash.getBytes(), sig,
          Args.getInstance().isECKeyCryptoEngine());