feat(*): optimize old rewards withdrawal #5742
Conversation
| logger.warn("Merkle root mismatch, expect: {}, actual: {}." | ||
| + " If you are quite sure that there is no miscalculation (not on the main network)" | ||
| + ", please configure 'storage.merkleRoot.reward-vi = {}'" | ||
| + "(for a specific network such as Nile, etc.) to config.conf to fix the hints", |
There was a problem hiding this comment.
a small spelling error.'to config.conf' should be 'in config.conf'.
| private Sha256Hash rewardViRoot = Sha256Hash.wrap( | ||
| ByteString.fromHex("9debcb9924055500aaae98cdee10501c5c39d4daa75800a996f4bdda73dbccd8")); | ||
| private static final String MAIN_NET_ROOT_HEX = | ||
| "9debcb9924055500aaae98cdee10501c5c39d4daa75800a996f4bdda73dbccd8"; |
There was a problem hiding this comment.
this root hex is already configured in conf. here it is declared again. Should it be possible for this value declared in one place instead of two different files？
There was a problem hiding this comment.
This is to ensure that the main-net node does not need to change the configuration file.
| checkValid(); | ||
| return dbIterator.peekNext().getKey(); | ||
| } | ||
|
|
||
| @Override | ||
| public byte[] getValue() { | ||
| checkState(); |
There was a problem hiding this comment.
There is a varible method close and a method with the same name in this class, maybe you should use different names to distinguish them.
There was a problem hiding this comment.
No changes for now.
| } | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
In which case shall it throw an Exception?
There was a problem hiding this comment.
Such as too many open files, not enough disk space, etc.
| private List<Leaf> leaves; | ||
| private Leaf root; | ||
|
|
||
| public static MerkleTree getInstance() { |
There was a problem hiding this comment.
here it uses Double-Checked Locking to ensure that only one instance is created in a multi-threaded environment. However, this code suffers from concurrency issues. Double-Checked Locking is not always reliable in Java because it depends on the memory model and compiler optimizations.
A safer implementation of the singleton pattern uses static inner classes in a way that is thread-safe and efficient。
private static class MerkleTreeHolder { private static final MerkleTree instance = new MerkleTree(); } public static MerkleTree getInstance() { return MerkleTreeHolder.instance; }
There was a problem hiding this comment.
This class has member variables and can not be used for concurrency, need to modify the usage scenarios while labeling them as not being able to be concurrent.
halibobo1205
force-pushed
the
feat/old_reward_cal_opt
branch
3 times, most recently
from
8b61106
to
03fa9d9
Compare
halibobo1205
force-pushed
the
feat/old_reward_cal_opt
branch
from
03fa9d9
to
f8cd49b
Compare
halibobo1205
force-pushed
the
feat/old_reward_cal_opt
branch
from
f8cd49b
to
4811675
Compare
halibobo1205
requested review from
yanghang8612,
317787106,
tomatoishealthy,
jwrct and
lurais
What does this PR do?
db rootto calculate the data rootWhy are these changes required?
see #5406 (comment).
This PR has been tested by:
Follow up
Extra details