Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drag and drop images into project #22

Closed
inukshuk opened this issue Jun 22, 2017 · 1 comment
Closed

Fix drag and drop images into project #22

inukshuk opened this issue Jun 22, 2017 · 1 comment
Labels
bug upstream
Milestone
1.2

Comments

@inukshuk
Copy link
Member

inukshuk commented Jun 22, 2017 •
edited

Caused by event.dataTransfer.files being empty before the drop event. Works in Electron 1.6 but fails in Electron 1.7.
@inukshuk inukshuk modified the milestone: 1.0 Aug 19, 2017
@inukshuk inukshuk removed this from the 1.0 milestone Oct 11, 2017
@inukshuk
Copy link
Member Author

See here for the upstream issue: electron/electron#9840

@inukshuk inukshuk added this to the 1.1 milestone Oct 21, 2017
@inukshuk inukshuk mentioned this issue Feb 26, 2018
Merged
11 tasks
@inukshuk inukshuk modified the milestones: 1.1, 1.2 Mar 13, 2018
@inukshuk inukshuk mentioned this issue May 17, 2018
Closed
inukshuk added a commit that referenced this issue Aug 19, 2018
@inukshuk
Work around #22 by using dataTransfer.item.type
959e2e0 
This works as long as the mime types are properly registered.
Need to verify this is the case on Linux and Windows.
inukshuk added a commit that referenced this issue Sep 13, 2018
@inukshuk
Work around #22 by using dataTransfer.item.type
3d0d3a2 
This works as long as the mime types are properly registered.
Need to verify this is the case on Linux and Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug upstream
Projects
None yet
Milestone
1.2
Development

No branches or pull requests
1 participant
@inukshuk