Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon not showing on IMDB #134

Closed
jakanaka opened this issue May 9, 2023 · 2 comments · Fixed by #139
Closed

Icon not showing on IMDB #134

jakanaka opened this issue May 9, 2023 · 2 comments · Fixed by #139
Assignees
@trossr32
Labels
bug Something isn't working

Comments

@jakanaka
Copy link

jakanaka commented May 9, 2023 •
edited

https://www.imdb.com/title/tt2494376/

I think this happens when a content is labeled as video on IMDB
@jakanaka
Copy link
Author

jakanaka commented May 9, 2023 •
edited

possible fix

sonarr-radarr-lidarr-autosearch-browser-extension/src/content/js/content_script.js

Line 55 in 965144b

pattern: /movie/i,

pattern: /(movie|other)/i,

I fell like both raderr and sonarr icon should show up if it is other

@trossr32 trossr32 self-assigned this May 24, 2023
@trossr32 trossr32 added the bug Something isn't working label May 24, 2023
trossr32 added a commit that referenced this issue May 24, 2023
@trossr32
fixes #134. imdb videos now show both radarr and servarr icons
480b9aa
@trossr32
Copy link
Owner

I agree that both icons should show; hopefully this is enough of an edge case that further issues won't be raised because 2 icons are showing. This will go up in the next release.

trossr32 added a commit that referenced this issue May 24, 2023
@trossr32
20230524 issues (#138)
1bd7ffd 
* fixes #131. caused by regex selecting minum of 4 digits for id, which has been changed to 2 digits.

* fixes #134. imdb videos now show both radarr and servarr icons

* update readme
@trossr32 trossr32 mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trossr32 trossr32

Labels
bug Something isn't working
Projects
servarr-ext bugs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

20230524 issues (#138) trossr32/sonarr-radarr-lidarr-autosearch-browser-extension
2 participants
@trossr32 @jakanaka