-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Good fix? Redirect blocked by ad blockers. #12
Comments
Does
There may be some website which self-host the entire thing (maybe?) |
I have/had not taken action because I had received no response to my question - "GOOD IDEA? ..." from @troyhunt or anyone. I suppose your comment is an implicit answer: Yes. And based on your self-description and commit history, you know what you're talking about. Your PR, tcptomato/ROad-Block#118 is cool - so well documented. If my creating this gave you the idea or drive, I'm happy. ( I don't really know enough to judge if it was appropriate but I'm surprised by the choice to move it to annoyances:
I guess we can close this as resolved by your actions? |
I've merged your PR. So I think you can close this ticket. |
I think there are other lists which block it though |
Yeah, CoinhiveDOTcom is still in NOCOIN - https://github.com/hoshsadiq/adblock-nocoin-list/blob/master/nocoin.txt, which @smed79 maintains and which is "Included" or "Active" by default in 5+ ad blockers. (I'd guess one can't @ people not in the project, but I'm trying anyway.) |
It should work... |
Removed from Nocoin list hoshsadiq/adblock-nocoin-list@b1e4551 & Liste FR easylist/listefr@5f23411 |
RESOLVED! OP: Woah there! Hold on-I see no evidence that Troy Hunt has control of coin-hive.com. The registration information is quite different than that for coinhive.com. Yes they currently redirect to the same site but that’s not good enough reason to delist the latter, I think not yet. PS I don’t think Troy has visited this thread yet so we probably need to contact him another way than @troyhunt. PPS @smed79 - maybe pause your pull requests or explain? PPPS I am emailing Troy as that is how he prefers to be contacted. PPPPS: Troy responded, below. |
@troyhunt Do you own |
@troyhunt can you clarify which ones you do/don't own (sorry for the redundant comment, didn't see #12 (comment) before posting) |
I also ping-ed him on Twitter |
https://coinhive.com/lib/coinhive.min.js & https://coinhive.com/lib/coinhive.js seems fine, no privacy issues or coin miner. Was removed already # edit. With the rest of coinhive, coinhiveproxy.com is a "dead domain" is there any sites using it? also |
Sorry folks, for some reason I got no alerts on this thread until someone on Twitter just pointed me to it, I'm not (deliberately) ignoring you! Here's all the "coin" domains I own: So yes, I do own coin-hive.com and am redirecting it to my blog post on Coinhive. I'm supportive of removing it from ad blockers simply to raise awareness of which sites currently have it embedded. That's obviously not my decision though and I don't know that it would really make a lot of difference as the majority of people visiting those sites won't have blockers anyway. But yeah, the more exposure the better 🙂 |
Hey. I agree that it should be removed, so it's gone now. |
Hi! I have removed it from AdGuard filters. |
Hi, @troyhunt & friends!
1️⃣GOOD IDEA?
My question is about coinhive (this project, that is) and ad blockers.
I propose we ask to have coinhive.com removed from ad blocker lists. I wonder if we should, and want to see if there's consensus first. Would it be good to reach more folks? Make the alert appear more consistently rather than on on users machines, only to not be reproducible on the machines of admins more likely to run ad blockers? I think it probably would.
2️⃣HOW?
In the case of the ad blocker I use⚚, it was added 5 years ago: github.com/dgraham/Ka-Block/blame/... /blockerList.json#L5218
They say to open a new issue here to request changes.
But the main thing is easylist, which is way more popular. It contains (in its sub-list easyprivacy's trackingservers sub-sub-list)
/coinhive.min.js
and I guess needs to continue to contain it. But the maintainers could be asked to remove||coinhive.com^$third-party
. They ask folks to start at the easylist forums.(So I'm not @ pinging the folks who added it or last edited the lists .
⚚ I ran into this by trying to create an account at http://forum.oldversion.com/forum.php - but only because I happened to turn off content blockers on the site. (I have used oldversion.com on occasion but the forum is a ghost town.) (And I've enjoyed your project write-ups many times, but hadn't seen this one.).
My claim to fame was an (almost successful?) legal effort to get brokers to submit to public security audits. FYI.
Also I wonder how many hits you get to other parts of the site like https://coinhive.com/documentation/authedmine. Interesting to see what it once looked like - someone was whining about it being added to easylist.
The text was updated successfully, but these errors were encountered: