Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional keys in favour of bootstrapping #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sfuerte
Copy link

@sfuerte sfuerte commented Oct 31, 2021

  • made the required keys optional, in favour of providing corresponding key_path variables during instance bootstrapping.
    Reasoning: when building an image, whether Docker, AWS AMI or anything else, it's better not include any sensitive information but rather include it upon container/instance bootstrapping.

  • minor reformatting

  • added a warning about not using variables invoking command line arguments with sensitive secrets, i.e. keys, passwords, etc. Use corresponding environment variables.
    Reasoning: leakage and exposure to procps and system logs.

$ ps axf  | grep concou
 365430 ?        Ssl    0:01 /opt/concourse/bin/concourse web ... --encryption-key <unencrypted key here>  .. --postgres-password <plain-text pass> ... --github-client-secret <plain-text token> ...

and here is an example of exported logs
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants