Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix label name in 03-proposal.md and add question issue template #15

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

longyue0521
Copy link
Contributor

  1. 新增question issue模版,自动打标签为question
  2. 修改proposal issue模版中标签名使其与github上创建的标签相同

Signed-off-by: longyue0521 <longyueli0521@gmail.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b8df59) 77.56983% compared to head (3ecede5) 77.82123%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main         #15         +/-   ##
===================================================
+ Coverage   77.56983%   77.82123%   +0.25140%     
===================================================
  Files             45          45                 
  Lines           3580        3580                 
===================================================
+ Hits            2777        2786          +9     
+ Misses           587         581          -6     
+ Partials         216         213          -3     
Flag Coverage Δ
unittests 77.82123% <ø> (+0.25140%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@WineChord WineChord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WineChord
Copy link
Contributor

WineChord commented Oct 26, 2023

@longyue0521 do you consider adding these patches to the main trpc-go repo?

@WineChord WineChord merged commit e2b4b5a into trpc-group:main Oct 26, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@longyue0521 longyue0521 deleted the add_question_template branch October 26, 2023 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants