fix: exclude *.test.*-files in build outputs
#4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KATT
commented
May 25, 2023
package.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "lint-prune": "! ts-prune | grep -v \"used in module\"", | |||
| "clean": "find . -name node_modules -o -name .turbo -o -name .next -o -name dist -type d -prune | xargs rm -rf", | |||
| "codegen:override-prisma": "tsx scripts/addPrismaOverrides.ts", | |||
| "codegen:entrypoints": "turbo --filter=\"@trpc/*\" codegen:entrypoints", | |||
There was a problem hiding this comment.
I am stupid and don't understand turbo completely, but in order to trigger this I had to do p codegen:entrypoints -- no-cache.
Not sure if this should even be here or if it should just be magically triggered 😅
There was a problem hiding this comment.
it should be triggered automatically on build
There was a problem hiding this comment.
That is what this says - each build script depends on the codegen:entrypoint task in that package
for reference if you would do ^codegen:entrypoints the build would depend on the task in all of it's dependencies, so client:build would depend on server:codegen:entrypoints
There was a problem hiding this comment.
maybe package.json should be in the outputs too actually - that's probably why it didn't trigger for you since the outputs were intact
package.json
Outdated
| @@ -22,6 +22,7 @@ | |||
| "lint-prune": "! ts-prune | grep -v \"used in module\"", | |||
| "clean": "find . -name node_modules -o -name .turbo -o -name .next -o -name dist -type d -prune | xargs rm -rf", | |||
| "codegen:override-prisma": "tsx scripts/addPrismaOverrides.ts", | |||
| "codegen:entrypoints": "turbo --filter=\"@trpc/*\" codegen:entrypoints", | |||
There was a problem hiding this comment.
Suggested change
| "codegen:entrypoints": "turbo --filter=\"@trpc/*\" codegen:entrypoints", |
KATT
commented
May 25, 2023
turbo.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "$schema": "https://turborepo.org/schema.json", | |||
| "globalDependencies": ["tsconfig.json", "scripts/entrypoints.ts"], | |||
There was a problem hiding this comment.
cc @juliusmarminge this seems to do it - looks good to you?
There was a problem hiding this comment.
im still getting the dev errors though
There was a problem hiding this comment.
yeah, I tried to fix that but got deralied and fixed this instead :D
mastondzn
added a commit
to mastondzn/synopsisbot
that referenced
this pull request
May 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@trpc/client](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.27.1` -> `10.28.0`](https://renovatebot.com/diffs/npm/@trpc%2fclient/10.27.1/10.28.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/react-query](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.27.1` -> `10.28.0`](https://renovatebot.com/diffs/npm/@trpc%2freact-query/10.27.1/10.28.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trpc/server](https://trpc.io) ([source](https://togithub.com/trpc/trpc)) | [`10.27.1` -> `10.28.0`](https://renovatebot.com/diffs/npm/@trpc%2fserver/10.27.1/10.28.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>trpc/trpc</summary> ### [`v10.28.0`](https://togithub.com/trpc/trpc/releases/tag/v10.28.0) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.27.3...v10.28.0) #### What's Changed - feat(`client`): allow closing active subscriptions by [@​Dealerpriest](https://togithub.com/Dealerpriest) in [trpc/trpc#4136 - feat(`client`): add ability to call `TRPCProxyClient`-methods with `.apply()` by [@​atoy40](https://togithub.com/atoy40) in [trpc/trpc#3973 - feat(`react-query`): allow optional cursor in `useInfiniteQuery` by [@​lithdew](https://togithub.com/lithdew) in [trpc/trpc#4374 - fix(`*`): exclude `*.test.*`-files in build outputs by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#4417 #### New Contributors - [@​atoy40](https://togithub.com/atoy40) made their first contribution in [trpc/trpc#3973 - [@​miguelvelasquezdev](https://togithub.com/miguelvelasquezdev) made their first contribution in [trpc/trpc#4341 - [@​lithdew](https://togithub.com/lithdew) made their first contribution in [trpc/trpc#4374 **Full Changelog**: trpc/trpc@v10.27.3...v10.28.0 ### [`v10.27.3`](https://togithub.com/trpc/trpc/releases/tag/v10.27.3) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.27.2...v10.27.3) #### What's Changed - fix(`react-query`): fix `useInfiniteQuery` `placeholderData` types by [@​SSHari](https://togithub.com/SSHari) in [trpc/trpc#4402 #### New Contributors - [@​SSHari](https://togithub.com/SSHari) made their first contribution in [trpc/trpc#4402 **Full Changelog**: trpc/trpc@v10.27.2...v10.27.3 ### [`v10.27.2`](https://togithub.com/trpc/trpc/releases/tag/v10.27.2) [Compare Source](https://togithub.com/trpc/trpc/compare/v10.27.1...v10.27.2) #### What's Changed - fix(`next)`: remove conditional hook in `withTRPC()` by [@​KATT](https://togithub.com/KATT) in [trpc/trpc#4410 **Full Changelog**: trpc/trpc@v10.27.1...v10.27.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/synopsisgg/bot). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDIuNCIsInVwZGF0ZWRJblZlciI6IjM1LjEwMi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes test files in build outputs
To test this I did