Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore me #5309

Closed
wants to merge 2 commits into from
Closed

ignore me #5309

wants to merge 2 commits into from

Conversation

KATT
Copy link
Member

@KATT KATT commented Jan 11, 2024

Closes #5308

🎯 Changes

Idea - if we ban imports from adapters in @trpc/core we should be able to ensure that anyone can build a trpc adapter

@KATT KATT changed the base branch from main to next January 11, 2024 10:38
Copy link

github-actions bot commented Jan 11, 2024

Diagnostics Comparison

Numbers

Metric PR next
Files 735 735 (➖ 0)
Lines of Library 40,241 40,241 (➖ 0)
Lines of Definitions 118,639 118,639 (➖ 0)
Lines of TypeScript 4,867 4,867 (➖ 0)
Lines of JavaScript 0 0 (➖ 0)
Lines of JSON 0 0 (➖ 0)
Lines of Other 0 0 (➖ 0)
Identifiers 174,807 174,807 (➖ 0)
Symbols 108,836 108,836 (➖ 0)
Types 89 89 (➖ 0)
Instantiations 0 0 (➖ 0)
Memory used 166,576 166,972 (🔽🟢 -396)
Assignability cache size 0 0 (➖ 0)
Identity cache size 0 0 (➖ 0)
Subtype cache size 0 0 (➖ 0)
Strict subtype cache size 0 0 (➖ 0)

Timings and averages

Metric PR next
max (s) 4.873 4.761 (🔺 0.11)
min (s) 4.873 4.761 (🔺 0.11)
avg (s) 4.873 4.761 (🔺 0.11)
median (s) 4.873 4.761 (🔺 0.11)
length 1 1 (➖ 0)
unstable timings

Unstable

Timings are not reliable in here

Metric PR next
I/O Read time 0.05 0.04 (🔺 0.01)
Parse time 0.75 0.73 (🔺 0.02)
ResolveTypeReference time 0.03 0.04 (🔽🟢 -0.01)
ResolveModule time 0.11 0.11 (➖ 0)
ResolveLibrary time 0.02 0.02 (➖ 0)
Program time 1.08 1.08 (➖ 0)
Bind time 0.48 0.45 (🔺 0.03)
Total time 1.57 1.53 (🔺 0.04)

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-prisma-starter ❌ Failed (Inspect) Jan 11, 2024 10:43am
og-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:43am
trpc-next-app-dir ❌ Failed (Inspect) Jan 11, 2024 10:43am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
www ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 10:43am

@KATT
Copy link
Member Author

KATT commented Jan 11, 2024

Opened wrong pr lol

@KATT KATT deleted the issues/5293-hydration branch January 11, 2024 11:00
@KATT KATT changed the title chore(server): ban imports of @trpc/core in adapters ignore me Jan 11, 2024
Copy link

This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(v11): make it easier to extend tRPC
1 participant