fix(sse): sse()-id not propagated
#5819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Previously deployed to Railway in the trpc-sse-and-websockets project. Environment has been deleted. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trpc-bot
previously approved these changes
Jun 22, 2024
trpc-bot
approved these changes
Jun 22, 2024
KATT
commented
Jun 22, 2024
| @@ -200,6 +200,11 @@ test('disconnect and reconnect with an event id', async () => { | |||
| expect(onData.mock.calls.length).toBeGreaterThan(5); | |||
| }); | |||
|
|
|||
| expect(onData.mock.calls[0]![0]).toEqual({ | |||
| data: 0, | |||
| id: '0', | |||
|
This pull request has been locked because we are very unlikely to see comments on closed issues. If you think, this PR is still necessary, create a new one with the same branch. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caused a bug where
idinsse({})wasn't propagated. Fixed it and added tests that the right thing is actually propagated