Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close issue if action cancelled #4

Merged
merged 8 commits into from Apr 28, 2022
Merged

Close issue if action cancelled #4

merged 8 commits into from Apr 28, 2022

Conversation

elmundio87
Copy link
Contributor

@elmundio87 elmundio87 commented Mar 30, 2022 •
edited

If the workflow is cancelled due to user intervention or job timeout, this will ensure that the associated GitHub issue is closed, before the action exits.

This is achieved by intercepting the kill signal that the Docker container receives on job cancellation, and moving the main comment loop into a separate goroutine.

This should prevent issues being left behind when pipeline runs are cancelled.

I am using this in conjunction with the timeout-minutes parameter, to prevent approvals from running for excessive amounts of time.

@elmundio87
Copy link
Contributor Author

git diff is having a tough time with this branch so I'll add some comments to highlight the main review areas

elmundio87
elmundio87 commented Apr 5, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
elmundio87
elmundio87 commented Apr 5, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
elmundio87
elmundio87 commented Apr 5, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
elmundio87
elmundio87 commented Apr 5, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
trstringer
trstringer requested changes Apr 6, 2022
View reviewed changes
main.go Outdated Show resolved Hide resolved
trstringer
trstringer requested changes Apr 7, 2022
View reviewed changes
Copy link
Owner

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the effort that you're putting into this! This is really great. Just some architectural and design changes to be made so that this project can scale from here. Thanks!

main.go Outdated Show resolved Hide resolved
trstringer
trstringer requested changes Apr 26, 2022
View reviewed changes
Copy link
Owner

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Single small request for changes, then we can get this merged in. Thanks!

main.go Outdated Show resolved Hide resolved
@trstringer trstringer merged commit c24bf80 into trstringer:main Apr 28, 2022
@trstringer
Copy link
Owner

Thank you for your contribution!

trstringer added a commit that referenced this pull request May 24, 2022
@trstringer
Release version 1.3.0
9ca6a8f 
This release contains two features:

* The ability to close the issue if the workflow was cancelled (#4)
* Debug logging for issue creation (#9)
@trstringer trstringer mentioned this pull request May 24, 2022
Merged
trstringer added a commit that referenced this pull request May 24, 2022
@trstringer
Release version 1.3.0 (#10)
984a23b 
This release contains two features:

* The ability to close the issue if the workflow was cancelled (#4)
* Debug logging for issue creation (#9)
@elmundio87 elmundio87 deleted the feature/close-issue-if-workflow-cancelled branch July 5, 2022 14:09
@trstringer trstringer mentioned this pull request Jul 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trstringer trstringer trstringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elmundio87 @trstringer