Create GH Actions CI Workflow #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
gh-actions
branch
from
53e83d9
to
69e96f1
Compare
This config runs the test suite against all supported Node versions on Ubuntu, and against the version in the `package.json` for macOS and Windows. (Running against all supported versions for all OSes would likely take a *very* long time, just because Windows is super slow. It's worth checking later, though.) The config uses Volta to manage the Node versions, so that we can be guaranteed it will use the same toolling as development. Resolves #61
chriskrycho
force-pushed
the
gh-actions
branch
from
69e96f1
to
aa21488
Compare
|
Will follow-on to reenable macOS builds when actions/runner-images#2247 is resolved. |
With GH actions in place, we no longer need to run Travis at all
bmakuh
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config runs the test suite against all supported Node versions on Ubuntu, and against the version in the
package.jsonfor macOS and Windows. (Running against all supported versions for all OSes would likely take a very long time, just because Windows is super slow. It's worth checking later, though.) The config uses Volta to manage the Node versions, so that we can be guaranteed it will use the same toolling as development.Contributes to #61 (fully resolving it also requires changing our repo settings)