This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Increase rfc compliance #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…55 octests (including seperator) (see RFC1034 and RFC2181)
|
Thanks for your contribution. I am not a big fan of the assignments in conditions, would it be too much to ask to clean that up a bit? |
|
@patrick-radius Thanks for your feedback. I've fixed it in the last commit. :) |
|
👍 LGTM, thanks! |
|
Created a new release including this change, v2.1.0 Thanks again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this beautiful library converts every domain with every length into it's punycode representation. But in RFC1034 and RFC2181 is defined that every label (or part) must be between 1 and 63 octets and a full domain name is limited to 255 octets (including the separators).
The idn_to_ascii functions returns an empty string if the given domain is invalid without trigger any error, but I don't think this is the best behaviour.
So I decided to make a pull request, to throw exceptions if an invalid domain is given.