Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme file #22

Closed
wants to merge 2 commits into from
Closed

Update readme file #22

wants to merge 2 commits into from

Conversation

hixichen
Copy link
Contributor

@hixichen hixichen commented Jul 8, 2018

Update readme file for build and test

Add logger for pbft.

How to use it:
    pbftLog(log.Info, "Client", "Get %s", var)
$ hmake check
$ hmake build
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't remove lines 80-89. People who're unaware of hmake could get a sense of usage here and saves the junior devs from panic. I think It's okay sometimes to include third party documentation partially.

@rnx211 rnx211 force-pushed the devel branch 2 times, most recently from fc1d888 to b4d074e Compare July 9, 2018 23:49
Update readme file for build and test
@arcolife
Copy link
Collaborator

covered in #21 and #57 (comment)

@arcolife arcolife closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants