Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor manifest file #7

Merged
merged 1 commit into from
May 24, 2018
Merged

Add vendor manifest file #7

merged 1 commit into from
May 24, 2018

Conversation

hixichen
Copy link
Contributor

Fix the dependency issue.
Try:

$hamke --targets
$hmake deps
after this, you should be able to see the dependency packages under src/vendor

$hamke build

@hixichen
Copy link
Contributor Author

I am sorry that you may have a hard time about this issue.
I should mention that the initial goal for the change:
The whole project will only require hmake and docker.
It can be built wherever you clone the code and need to care about the gopath.

@hixichen hixichen changed the title Billing: add vendor manifest file Add vendor manifest file May 23, 2018
@arcolife arcolife merged commit e8bd63d into truechain:devel May 24, 2018
@arcolife
Copy link
Collaborator

arcolife commented Jun 2, 2018

Hi @hixichen
Could we have a quick call sometime this week? if possible, today or tomorrow?
Need to discuss a few things about this build PR we've picked up.

example:

  • need to discuss about hmake, dep vs gvt etc.
  • our code is now self-importing, so the local build with ./support/scripts/build.sh passes, after I change pbft-core to pbft "github.com/truechain/truechain-consensus-core/src/pbft-core" but fails in container obviously because vendor manifest doesn't have it. But that's the thing, while developing if I change something in my current environment, the container build will always work off of the copy of the project codebase itself in vendor/ folder. Which means I'm working with a stale copy all the time. How do we solve this?

I'm sending you an email to your address on your profile.

thanks!

@hixichen
Copy link
Contributor Author

hixichen commented Jun 2, 2018

hi , I sent you my contact info.
I am in PST timezone .

to clarify:

  1. build:
    please do: $hmake build

  2. pkg:
    local pkg under src/ , you can import with name directly
    outside pkg: use gvt , https://github.com/FiloSottile/gvt
    eg: gvt fetch, then modify the manifest file.

Let us schedule a time, and I can go through the build/test work and get your questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants