Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(promtail): add our own promtail dependency App #1394

Merged
merged 19 commits into from
Nov 24, 2021
Merged

Conversation

PrivatePuffin
Copy link
Member

@PrivatePuffin PrivatePuffin commented Nov 24, 2021

Description
The Promtail dependency for Loki has some issues with the location of the docker container logs on SCALE.
So we build our own to add as a dependency to our Loki App

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@PrivatePuffin PrivatePuffin added the enhancement New feature or request label Nov 24, 2021
@PrivatePuffin PrivatePuffin added this to the TrueNAS SCALE 22.02 RC2 milestone Nov 24, 2021
@PrivatePuffin PrivatePuffin self-assigned this Nov 24, 2021
@PrivatePuffin PrivatePuffin marked this pull request as draft November 24, 2021 14:05
@PrivatePuffin PrivatePuffin marked this pull request as ready for review November 24, 2021 16:40
@PrivatePuffin PrivatePuffin merged commit fe7eff7 into master Nov 24, 2021
@PrivatePuffin PrivatePuffin deleted the promtail branch November 28, 2021 14:33
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants