Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n): Fix permissions and add healthcheck path #1809

Merged
merged 5 commits into from
Jan 30, 2022

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Jan 28, 2022

Description

Fixes #

Removed /home/node/.n8n persistence as the /data is used correctly now, and it actually stores the data there.

It needs to have runAsUser: 0

runAsGroup can be ANYTHING. (It starts and can create files through GUI, without errors with any user I tried)
fsGroup HAS to be 1000 (node user)

No idea while tests was passing tests here on CI (with the initial perms), but wouldn't deploy on SCALE (with pvc).
While it would deploy fine with emptyDir

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@stavros-k stavros-k changed the title N8nagain fix(n8n): Remove custom data path Jan 29, 2022
@stavros-k stavros-k marked this pull request as draft January 29, 2022 07:55
@stavros-k stavros-k marked this pull request as ready for review January 29, 2022 09:23
@stavros-k stavros-k changed the title fix(n8n): Remove custom data path fix(n8n): Fix permissions and add healthcheck path Jan 30, 2022
@PrivatePuffin PrivatePuffin merged commit 58cfb8a into truecharts:master Jan 30, 2022
@stavros-k stavros-k deleted the n8nagain branch January 30, 2022 12:58
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants