Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(traefik): Add stripPrefixRegex #2422

Merged
merged 4 commits into from
Apr 4, 2022
Merged

feat(traefik): Add stripPrefixRegex #2422

merged 4 commits into from
Apr 4, 2022

Conversation

stdedos
Copy link
Contributor

@stdedos stdedos commented Apr 4, 2022 •
edited
Loading

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

It hasn't, but then again I was instructed to just open a PR for it https://discord.com/channels/830763548678291466/886351979306188811/960460336572551168

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

@stdedos
feat(traefic): Add stripPrefixRegex
df9feea 
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@truecharts-admin truecharts-admin added the size/S Categorises a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2022
@PrivatePuffin PrivatePuffin changed the title feat(traefic): Add stripPrefixRegex feat(traefik): Add stripPrefixRegex Apr 4, 2022
PrivatePuffin
PrivatePuffin requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the required minor version bump in Chart.yaml and the definition + comments in values.yaml

@truecharts-admin truecharts-admin added precommit:ok CI status: pre-commit validation successful lint:ok CI status: linting successful install:ok CI status: install successful labels Apr 4, 2022
@stdedos
feat(traefik): Add stripPrefixRegex: Part 2
34956dd 
> I'm missing the required minor version bump in Chart.yaml and the definition + comments in values.yaml

Additionally, add the changelog entry to-be

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@truecharts-admin truecharts-admin added size/M Categorises a PR that changes 30-99 lines, ignoring generated files. and removed size/S Categorises a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2022
PrivatePuffin
PrivatePuffin requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comments

@stdedos
feat(traefik): Add stripPrefixRegex: Oops
d79292e 
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@truecharts-admin truecharts-admin added size/S Categorises a PR that changes 10-29 lines, ignoring generated files. and removed size/M Categorises a PR that changes 30-99 lines, ignoring generated files. labels Apr 4, 2022
@stdedos
Copy link
Contributor Author

stdedos commented Apr 4, 2022

Oops 😓

Hopefully it's clean now 🙏

PrivatePuffin
PrivatePuffin approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! :)
Thank you for your submission, may users inter-alia requested this.

Your Helm templating skills are quite good though :)

@all-contributors please add @stdedos for code

@PrivatePuffin PrivatePuffin merged commit 5ac0465 into truecharts:master Apr 4, 2022
@stavros-k
Copy link
Member

@all-contributors please add @stdedos for code

@allcontributors allcontributors bot mentioned this pull request Apr 4, 2022
Merged
@allcontributors
Copy link
Contributor

@stavros-k

I've put up a pull request to add @stdedos! 🎉

@stdedos
Copy link
Contributor Author

stdedos commented Apr 4, 2022 •
edited
Loading

Looks fine to me! :) Thank you for your submission, may users inter-alia requested this.

It took me around 6h-8h bootstrapping (traefik, repo, instructions, piecing together etc), I am glad it was that easy at the end to merge!

Your Helm templating skills are quite good though :)

No, my investigation skills are good enough; my goofness too 😛
Helm has nothing to do with it.

e.g. I have no idea why/how I missed your first comment; nor "what does it mean" anyway.

@all-contributors please add @stdedos for code

Any "plans" when is this going live?

@allcontributors
Copy link
Contributor

@stdedos

I've updated the pull request to add @stdedos! 🎉

@stdedos stdedos deleted the feat/traefic/add-stripPrefixRegex branch April 4, 2022 19:53
@PrivatePuffin
Copy link
Member

Well, I rather have fine copy-pasters than mediocre coders ;-)

New version should be online in a few minutes or so :)
Be sure to bash that refresh button on SCALE :)

@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PrivatePuffin PrivatePuffin PrivatePuffin approved these changes

Assignees
No one assigned
Labels
install:ok CI status: install successful lint:ok CI status: linting successful precommit:ok CI status: pre-commit validation successful size/S Categorises a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stdedos @stavros-k @PrivatePuffin @truecharts-admin