Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(immich): cleanup and fix gpu allocation #19408

Merged
merged 2 commits into from Mar 23, 2024
Merged

chore(immich): cleanup and fix gpu allocation #19408

merged 2 commits into from Mar 23, 2024

Conversation

stavros-k
Copy link
Member

@stavros-k stavros-k commented Mar 17, 2024

Description

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@stavros-k stavros-k requested review from Ornias1993 and a team as code owners March 17, 2024 09:55
Comment on lines 9 to 11
{{- with .Values.immich.public_login_page_message }}
PUBLIC_LOGIN_PAGE_MESSAGE: {{ . }}
{{- end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer exists as a var

@stavros-k
Copy link
Member Author

See truecharts/library-charts#757 first

@stavros-k stavros-k marked this pull request as draft March 17, 2024 10:48
@stavros-k stavros-k marked this pull request as ready for review March 23, 2024 07:32
@stavros-k stavros-k requested a review from a team as a code owner March 23, 2024 07:32
@stavros-k stavros-k requested a review from xstar97 March 23, 2024 07:32
Copy link

📝 Linting results:

✔️ Linting [charts/stable/immich]: Passed - Took 1 seconds
Total Charts Linted: 1
Total Charts Passed: 1
Total Charts Failed: 0

✅ Linting: Passed - Took 1 seconds

@stavros-k stavros-k merged commit 87bf586 into master Mar 23, 2024
15 checks passed
@stavros-k stavros-k deleted the immich branch March 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant