Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(immich): cleanup and fix gpu allocation #19408

Merged
merged 2 commits into from
Mar 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/stable/immich/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ sources:
- https://hub.docker.com/r/altran1502/immich-machine-learning
- https://hub.docker.com/r/altran1502/immich-server
type: application
version: 14.2.0
version: 14.2.1
6 changes: 0 additions & 6 deletions charts/stable/immich/questions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,6 @@ questions:
additional_attrs: true
type: dict
attrs:
- variable: public_login_page_message
label: Public Login Page Message
description: Custom message on the login page, should be written in HTML form.
schema:
type: string
default: ""
- variable: log_level
label: Log Level
schema:
Expand Down
3 changes: 0 additions & 3 deletions charts/stable/immich/templates/_config.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ configmap:
enabled: true
data:
SERVER_PORT: {{ .Values.service.main.ports.main.port | quote }}
{{- with .Values.immich.public_login_page_message }}
PUBLIC_LOGIN_PAGE_MESSAGE: {{ . }}
{{- end }}

micro-config:
enabled: true
Expand Down
2 changes: 1 addition & 1 deletion charts/stable/immich/templates/_machinelearning.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ podSpec:
machinelearning:
enabled: true
primary: true
imageSelector: "{{ $img }}"
imageSelector: {{ $img }}
securityContext:
capabilities:
disableS6Caps: true
Expand Down
2 changes: 2 additions & 0 deletions charts/stable/immich/templates/_server.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
enabled: true
primary: true
imageSelector: image
resources:
excludeExtra: true
command: /bin/sh
args:
- -c
Expand Down
2 changes: 2 additions & 0 deletions charts/stable/immich/templates/_wait.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
enabled: true
type: init
imageSelector: alpineImage
resources:
excludeExtra: true
command:
- /bin/ash
- -c
Expand Down
7 changes: 0 additions & 7 deletions charts/stable/immich/templates/common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,6 @@
{{- $_ := set .Values.service.machinelearning "enabled" false -}}
{{- end -}}

{{/* Set targetselector for GPU to microservices */}}
{{- range $gpuEntry := .Values.scaleGPU }}
{{- if $gpuEntry.gpu -}}
{{- $_ := set $gpuEntry "targetSelector" (dict "microservices" (list "microservices")) -}}
{{- end -}}
{{- end -}}

{{/* Render configuration for immich
after services, as it has references
*/}}
Expand Down
1 change: 0 additions & 1 deletion charts/stable/immich/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ securityContext:
immich:
enable_ml: true
mlImageType: mlImage
public_login_page_message: Immich
log_level: log

service:
Expand Down