Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stash): add /blobs PVC storage #10852

Merged
merged 2 commits into from Jul 26, 2023

Conversation

schnerring
Copy link
Contributor

@schnerring schnerring commented Jul 26, 2023

Description

As per v0.20.0 release notes:

The Filesystem storage system is recommended for large libraries, and is the default for new systems.

Docker users: please ensure that the Binary Data filesystem path is mapped to a persistent location if you choose to use the Filesystem binary storage type. Not doing so may result your binary data (scene covers, performer images etc) being lost.

This PR adds the binary storage PVC at /blobs (the install wizard default).

I also noticed that the questions.yaml doesn't allow customizing the /generated PVC. It was added in 3c90d1f. Was this intended or an oversight @xstar97?

⚒️ Fixes #

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🪞 I have opened a PR on truecharts/containers adding the container to TrueCharts mirror repo.
  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@schnerring schnerring requested review from a team and Ornias1993 as code owners July 26, 2023 02:22
@xstar97
Copy link
Contributor

xstar97 commented Jul 26, 2023

I also noticed that the questions.yaml doesn't allow customizing the /generated PVC. It was added in 3c90d1f. Was this intended or an oversight @xstar97?

it was not, feel free to add.

@Ornias1993 Ornias1993 merged commit 865d3c4 into truecharts:master Jul 26, 2023
15 checks passed
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants